Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Remove StateStoreExtensions #3450

Merged
merged 2 commits into from
Oct 6, 2023
Merged

🧹 Remove StateStoreExtensions #3450

merged 2 commits into from
Oct 6, 2023

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented Oct 6, 2023 •
edited
Loading

Resolves #3323.

@greymistcube greymistcube self-assigned this Oct 6, 2023
@greymistcube greymistcube changed the title Remove unnecessary code 🧹 Remove StateStoreExtensions Oct 6, 2023
@greymistcube greymistcube marked this pull request as ready for review October 6, 2023 06:43
riemannulus
riemannulus reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does StateStoreExteions no longer exist use case? Have you been sure about NineChronicles.Snapshot too?

@greymistcube
Copy link
Contributor Author

@riemannulus
Eh, maybe you are right. I'll have to check. From the looks of it however:

  • I believe whatever NineChronicles.Snapshot requires, it should be achievable using public APIs present.
  • I don't see it as good enough reason to keep these extension methods around.

@riemannulus
Copy link
Member

I believe whatever NineChronicles.Snapshot requires, it should be achievable using public APIs present.

I agree with your opinion, but we need to move this extension(or function) to NineChronicles.Snapshot when it is used there. Just that much.

@greymistcube
Copy link
Contributor Author

@riemannulus
I Just checked, there is only a single instance of using ContainsStateRoot() which can be easily replaced. 😗

@greymistcube greymistcube merged commit 2b1ae63 into planetarium:main Oct 6, 2023
11 checks passed
@greymistcube greymistcube deleted the refactor/cleanup-state-store-extensions branch January 4, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riemannulus riemannulus riemannulus approved these changes

Assignees

@greymistcube greymistcube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup StateStoreExtension
2 participants
@greymistcube @riemannulus