Merge pull request #3976 from Songhee120/pk-exception

Raise exception on libplanet for zero byte prive key
planetarium · Oct 27, 2024 · 625e617 · 625e617
2 parents 2b8189d + 2c8ca49
commit 625e617
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Libplanet.Crypto/PrivateKey.cs b/src/Libplanet.Crypto/PrivateKey.cs
@@ -405,6 +405,11 @@ private static ECPrivateKeyParameters GenerateKeyParam()
 
         private static ECPrivateKeyParameters GenerateKeyFromBytes(byte[] privateKey)
         {
+            if (privateKey.All(b => b.Equals(0x00)))
+            {
+                throw new ArgumentException("Every bytes in Private key is zero value.");
+            }
+
             var param = new ECPrivateKeyParameters(
                 "ECDSA",
                 new BigInteger(1, privateKey),

diff --git a/test/Libplanet.Tests/Crypto/PrivateKeyTest.cs b/test/Libplanet.Tests/Crypto/PrivateKeyTest.cs
@@ -360,5 +360,18 @@ public void PrivateKeyGenerateLongerThan31Bytes()
 
             Assert.Empty(faults);
         }
+
+        [Theory]
+        [InlineData(new byte[]
+        {
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+        })]
+        public void ThrowsWhenZeroBytesPrivateKey(byte[] bytes)
+        {
+            Assert.Throws<ArgumentException>(() => new PrivateKey(bytes));
+        }
     }
-}
+}