Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge development to 1.18.0 (optimize action) #2846

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Conversation

eugene-doobu
Copy link
Member

for optimize action

@eugene-doobu eugene-doobu self-assigned this Sep 24, 2024
@eugene-doobu eugene-doobu requested review from U-lis and ipdae September 24, 2024 04:38
@eugene-doobu eugene-doobu added this to the v230.0.0 milestone Sep 24, 2024
@eugene-doobu eugene-doobu linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Member

@ipdae ipdae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 PR의 변경사항과는 직접적으로 관련이 없지만 UnlockCombinationSlot 액션 내부에서 context.Signer와 agentAddress가 동일한지에 대한 검증이 없는것 같습니다. 악용될 여지가 있으니 이 부분을 추가해야할 것 같습니다.

@eugene-doobu eugene-doobu marked this pull request as draft September 24, 2024 05:06
@eugene-doobu
Copy link
Member Author

eugene-doobu commented Sep 24, 2024

#2848 해당 pr dev로 머지 후 open하겠습니다 @ipdae

#2846 (review)

@eugene-doobu eugene-doobu marked this pull request as ready for review September 25, 2024 08:21
@U-lis U-lis requested a review from ipdae September 25, 2024 08:22
@eugene-doobu eugene-doobu merged commit 2a67d14 into release/1.18.0 Sep 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Optimize UnlockCombinationSlot action
4 participants