chore: Change MigrateDelegationHeight as admin action

planetarium · Nov 25, 2024 · df449d9 · df449d9
1 parent 0444528
commit df449d9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/Lib9c/Action/Guild/Migration/LegacyModels/MigrationModule.cs b/Lib9c/Action/Guild/Migration/LegacyModels/MigrationModule.cs
@@ -1,4 +1,3 @@
-using System;
 using Bencodex.Types;
 using Libplanet.Action.State;
 using Libplanet.Crypto;
@@ -23,11 +22,6 @@ public static readonly Address DelegationMigrationHeight
 
         public static IWorld SetDelegationMigrationHeight(this IWorld world, long height)
         {
-            if (world.GetDelegationMigrationHeight() is long)
-            {
-                throw new InvalidOperationException("Cannot overwrite delegation migration index.");
-            }
-
             return world
                 .MutateAccount(
                     Addresses.Migration,

diff --git a/Lib9c/Action/Guild/Migration/MigrateDelegationHeight.cs b/Lib9c/Action/Guild/Migration/MigrateDelegationHeight.cs
@@ -3,6 +3,7 @@
 using Libplanet.Action;
 using Libplanet.Action.State;
 using Nekoyume.Action.Guild.Migration.LegacyModels;
+using Nekoyume.Model.State;
 
 namespace Nekoyume.Action.Guild.Migration
 {
@@ -53,6 +54,16 @@ public override IWorld Execute(IActionContext context)
 
             var world = context.PreviousState;
 
+            if (!TryGetAdminState(context, out AdminState adminState))
+            {
+                throw new InvalidOperationException("Couldn't find admin state");
+            }
+
+            if (context.Signer != adminState.AdminAddress)
+            {
+                throw new PermissionDeniedException(adminState, context.Signer);
+            }
+
             return world.SetDelegationMigrationHeight(Height);
         }
     }