Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add messagepack exception handle #6639

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jonny-jeahyunchoi
Copy link
Contributor

메세지팩 역직렬화 실패관련 익셉션 헨들링 코드를 추가합니다.

원인 에러

[RPCAgent] OnRender()... Failed to deserialize ActionEvaluation. MessagePack.MessagePackSerializationException: Failed to deserialize Nekoyume.Action.NCActionEvaluation value. ---> System.NotSupportedException: MessagePackWriter/Reader overload is not supported in MessagePackSerializer.NonGenerics.
  at MessagePack.MessagePackSerializer+CompiledMethods.ThrowRefStructNotSupported () [0x00001] in C:\Planetarium_Corp\NineChronicles\nekoyume\Library\PackageCache\com.neuecc.messagepack@0c02b688ab\MessagePackSerializer.NonGeneric.cs:325 
  at MessagePack.MessagePackSerializer+CompiledMethods+<>c.<.ctor>b__13_5 (MessagePack.MessagePackReader& reader, MessagePack.MessagePackSerializerOptions options) [0x00001] in C:\Planetarium_Corp\NineChronicles\nekoyume\Library\PackageCache\com.neuecc.messagepack@0c02b688ab\MessagePackSerializer.NonGeneric.cs:251 
  at MessagePack.MessagePackSerializer.Deserialize (System.Type type, MessagePack.MessagePackReader& reader, MessagePack.MessagePackSerializerOptions options) [0x00001] in C:\Planetarium_Corp\NineChronicles\nekoyume\Library\PackageCache\com.neuecc.messagepack@0c02b688ab\MessagePackSerializer.NonGeneric.cs:58 
  at Lib9c.Formatters.ExceptionFormatter`1[T].Deserialize (MessagePack.MessagePackReader& reader, MessagePack.MessagePackSerializerOptions options) [0x000e3] in C:\Planetarium_Corp\NineChronicles\nekoyume\Assets\_Scripts\Lib9c\lib9c\Lib9c.MessagePack\Formatters\ExceptionFormatter.cs:79 
  at MessagePack.Formatters.Nekoyume.Action.NCActionEvaluationFormatter.Deserialize (MessagePack.MessagePackReader& reader, MessagePack.MessagePackSerializerOptions options) [0x000e2] in C:\Planetarium_Corp\NineChronicles\nekoyume\Assets\_Scripts\AOTGenerated\MessagePack.generated.cs:165 
  at MessagePack.MessagePackSerializer.Deserialize[T] (MessagePack.MessagePackReader& reader, MessagePack.MessagePackSerializerOptions options) [0x0008f] in C:\Planetarium_Corp\NineChronicles\nekoyume\Library\PackageCache\com.neuecc.messagepack@0c02b688ab\MessagePackSerializer.cs:250 
   --- End of inner exception stack trace ---
  at MessagePack.MessagePackSerializer.Deserialize[T] (MessagePack.MessagePackReader& reader, MessagePack.MessagePackSerializerOptions options) [0x000a8] in C:\Planetarium_Corp\NineChronicles\nekoyume\Library\PackageCache\com.neuecc.messagepack@0c02b688ab\MessagePackSerializer.cs:255 
  at MessagePack.MessagePackSerializer.Deserialize[T] (System.ReadOnlyMemory`1[T] buffer, MessagePack.MessagePackSerializerOptions options, System.Threading.CancellationToken cancellationToken) [0x00014] in C:\Planetarium_Corp\NineChronicles\nekoyume\Library\PackageCache\com.neuecc.messagepack@0c02b688ab\MessagePackSerializer.cs:274 
  at Nekoyume.Blockchain.RPCAgent.OnRender (System.Byte[] evaluation) [0x00033] in C:\Planetarium_Corp\NineChronicles\nekoyume\Assets\_Scripts\Blockchain\RPCAgent.cs:933 
UnityEngine.Debug:LogError (object)
UberLogger.Logger:ForwardToUnity (UnityEngine.Object,UberLogger.LogSeverity,object,object[]) (at Assets/_Scripts/Debugger/UberLogger/UberLogger.cs:711)
UberLogger.Logger:Log (string,UnityEngine.Object,UberLogger.LogSeverity,object,object[]) (at Assets/_Scripts/Debugger/UberLogger/UberLogger.cs:661)
UberDebug:LogErrorChannel (string,string,object[]) (at Assets/_Scripts/Debugger/UberLogger/UberDebug.cs:103)
Nekoyume.NcDebug:LogError (object,string) (at Assets/_Scripts/Debugger/NcDebug.cs:76)
Nekoyume.Blockchain.RPCAgent:OnRender (byte[]) (at Assets/_Scripts/Blockchain/RPCAgent.cs:939)
Nekoyume.Shared.Hubs.ActionEvaluationHubClient:OnBroadcastEvent (int,System.ArraySegment`1<byte>) (at Assets/_Scripts/AOTGenerated/MagicOnion.Generated.cs:451)
MagicOnion.Client.StreamingHubClientBase`2<Nekoyume.Shared.Hubs.IActionEvaluationHub, Nekoyume.Shared.Hubs.IActionEvaluationHubReceiver>:<ConsumeData>b__27_0 (object) (at Library/PackageCache/com.cysharp.magiconion@184b492382/MagicOnion.Client/StreamingHubClientBase.cs:252)
UnityEngine.UnitySynchronizationContext:ExecuteTasks ()

Copy link

@jonny-jeahyunchoi The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:

  • Libplanet submdoule:
  • Libplanet.Action.dll: 5.4.0
  • Libplanet.Common.dll: 5.4.0
  • Libplanet.Crypto.dll: 5.4.0
  • Libplanet.Mocks.dll: 5.4.0
  • Libplanet.RocksDBStore.dll: 5.4.0
  • Libplanet.Store.dll: 5.4.0
  • Libplanet.Types.dll: 5.4.0
  • Libplanet.dll: 5.4.0

Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:

/update-libplanet-dlls

@jonny-jeahyunchoi jonny-jeahyunchoi modified the milestones: v260.0.0, v270.0.0 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants