Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment for maintainability #2513

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Add comment for maintainability #2513

wants to merge 4 commits into from

Conversation

Akamig
Copy link
Member

@Akamig Akamig commented Dec 16, 2024

  • Fixed missing version number change
  • Remove aws-sink-cloudwatch-guid and PlayerUpdateRetryCount related logic
  • Added comments at main process and the entry point of renderer

@Akamig Akamig requested a review from ipdae December 16, 2024 08:48
@Akamig Akamig self-assigned this Dec 16, 2024
ipdae
ipdae reviewed Dec 26, 2024
View reviewed changes
Copy link
Member

@ipdae ipdae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단순 주석추가가 아니라 삭제된 코드가 있는데 의도된건가요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipdae ipdae ipdae left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Akamig Akamig

Labels
None yet
Projects
Nine Chronicles
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akamig @ipdae