Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y fixes #36

Open
wants to merge 18 commits into
base: production
Choose a base branch
from
Open

A11y fixes #36

wants to merge 18 commits into from

Commits on Jul 19, 2020

  1. Removed tabindex="-1" from all buttons 

    This was making the whole UI inaccessible for keyboard-only users
    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    3b1b923 View commit details
    Browse the repository at this point in the history

  2. Provided button labels with aria-labelledby 

    All buttons were missing an accessible name (the inner content was being stripped by the tooltip effect. Fixed by adding id to the inner <span> and referencing it with aria-labelledby
    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    5a7c436 View commit details
    Browse the repository at this point in the history

  3. Added region and group roles 

    Allows for screen reader users to jump from region to region more easily
    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    812116d View commit details
    Browse the repository at this point in the history

  4. Typo on action. => actions.

    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    c605c64 View commit details
    Browse the repository at this point in the history

  5. Removed maximum-scale restriction to allow users to zoom

    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    dec6633 View commit details
    Browse the repository at this point in the history

  6. Made 'load sample' link accessible 

    Changed wording (should avoid 'click here phrases', and link phrase now makes sense out of context ("load a sample audio file")
    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    b8d4977 View commit details
    Browse the repository at this point in the history

  7. Dialog naming fixes

    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    5a2d30c View commit details
    Browse the repository at this point in the history

  8. Added focus styles for all main controls 

    Doubled up on all hover styles with :focus equivalent
Added new styles for all .pk_btn buttons
    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    dcc4d1b View commit details
    Browse the repository at this point in the history

  9. Used aria-label instead of aria-labelledby

    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    8ca8cb0 View commit details
    Browse the repository at this point in the history

  10. Slight fix for global focus style

    @lloydi
    lloydi committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    50886c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Added a skip link to main toolbar that appears on keyboard focus

    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ef00921 View commit details
    Browse the repository at this point in the history

  2. Update tabindex to toolbar to -1

    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    c42cb40 View commit details
    Browse the repository at this point in the history

  3. More tweaks to dialog 

    Set focus on OK button on load
Changed link phrase for Githib so link makes sanes out of context
    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2587ebe View commit details
    Browse the repository at this point in the history

  4. Alt attribute for phone switch

    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    4c900cf View commit details
    Browse the repository at this point in the history

  5. Added alt attributes for images in About page

    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    6f8eea3 View commit details
    Browse the repository at this point in the history

  6. Set role to application

    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2cf2e55 View commit details
    Browse the repository at this point in the history

  7. Making a start on creating a global button state function

    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ac409e8 View commit details
    Browse the repository at this point in the history

  8. Making a start on creating a global button state function

    @lloydi
    lloydi committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2921d76 View commit details
    Browse the repository at this point in the history