Issue checkstyle#13213: remove //ok from finallocalvariable

piyush-1234 · Jan 30, 2024 · a457fb4 · a457fb4
1 parent 77eef9a
commit a457fb4
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 27 deletions.
diff --git a/config/checkstyle-input-suppressions.xml b/config/checkstyle-input-suppressions.xml
@@ -114,24 +114,6 @@
             files="checks[\\/]coding[\\/]equalshashcode[\\/]InputEqualsHashCodeSemantic.java"/>
   <suppress id="UnnecessaryOkComment"
             files="checks[\\/]coding[\\/]equalshashcode[\\/]InputEqualsHashCodeSemantic.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableConstructor.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableConstructor.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableFalsePositive.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableLeavingSlistToken.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableMultiCatch.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableMultipleAndNestedConditions.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableNativeMethods.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableReceiverParameter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableSwitchStatement.java"/>
   <suppress id="UnnecessaryOkComment"
             files="checks[\\/]coding[\\/]hiddenfield[\\/]InputHiddenField8.java"/>
   <suppress id="UnnecessaryOkComment"

diff --git a/...tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableConstructor.java b/...tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableConstructor.java
@@ -26,10 +26,10 @@ public class InputFinalLocalVariableConstructor {
 
 class Mutation {
 
-    Mutation(final int a) { // ok
+    Mutation(final int a) {
     }
 
-    Mutation(final String check) { // ok
+    Mutation(final String check) {
     }
 
     Mutation(String str, final int b) {

diff --git a/...ols/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableFalsePositive.java b/...ols/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableFalsePositive.java
@@ -8,7 +8,7 @@
 
 package com.puppycrawl.tools.checkstyle.checks.coding.finallocalvariable;
 
-public class InputFinalLocalVariableFalsePositive // ok
+public class InputFinalLocalVariableFalsePositive
 {
     public void method()
     {

diff --git a/...checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableLeavingSlistToken.java b/...checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableLeavingSlistToken.java
@@ -10,7 +10,7 @@
 
 import java.util.stream.Stream;
 
-public class InputFinalLocalVariableLeavingSlistToken { // ok
+public class InputFinalLocalVariableLeavingSlistToken {
 
     private int assignedInInstanceInitAndCtor;
     private static int assignedInStaticInitAndFoo1;

diff --git a/.../tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableMultiCatch.java b/.../tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableMultiCatch.java
@@ -8,7 +8,7 @@
 
 package com.puppycrawl.tools.checkstyle.checks.coding.finallocalvariable;
 
-public class InputFinalLocalVariableMultiCatch { // ok
+public class InputFinalLocalVariableMultiCatch {
     public void demo() throws Throwable {
         try {
             // do nothing

diff --git a/.../checks/coding/finallocalvariable/InputFinalLocalVariableMultipleAndNestedConditions.java b/.../checks/coding/finallocalvariable/InputFinalLocalVariableMultipleAndNestedConditions.java
@@ -8,7 +8,7 @@
 
 package com.puppycrawl.tools.checkstyle.checks.coding.finallocalvariable;
 
-public class InputFinalLocalVariableMultipleAndNestedConditions { // ok
+public class InputFinalLocalVariableMultipleAndNestedConditions {
 
     // False positive
     // https://github.com/checkstyle/checkstyle/issues/3186

diff --git a/...ols/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableNativeMethods.java b/...ols/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableNativeMethods.java
@@ -8,7 +8,7 @@
 
 package com.puppycrawl.tools.checkstyle.checks.coding.finallocalvariable;
 
-public class InputFinalLocalVariableNativeMethods // ok
+public class InputFinalLocalVariableNativeMethods
 {
     public native String nativeFoo(int a, int b);
     private native double average(int n1, int n2);

diff --git a/...checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableReceiverParameter.java b/...checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableReceiverParameter.java
@@ -8,7 +8,7 @@
 
 package com.puppycrawl.tools.checkstyle.checks.coding.finallocalvariable;
 
-public class InputFinalLocalVariableReceiverParameter { // ok
+public class InputFinalLocalVariableReceiverParameter {
     public void foo4(InputFinalLocalVariableReceiverParameter this)
     {
     }

diff --git a/...s/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableSwitchStatement.java b/...s/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableSwitchStatement.java
@@ -15,7 +15,7 @@ enum T {
     }
 
     public void foo() {
-        int x; // ok
+        int x;
 
         {
             final T y = T.A;