Skip to content

Commit

Permalink
Dont append random chars to uploaded dataset ids because theyre not f…
Browse files Browse the repository at this point in the history
…ound by lambda
  • Loading branch information
Peter Nemere committed Mar 26, 2024
1 parent 12c1030 commit 4fd782d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions api/ws/handlers/scan.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ func HandleScanUploadReq(req *protos.ScanUploadReq, hctx wsHelpers.HandlerContex
destBucket := hctx.Svcs.Config.ManualUploadBucket
fs := hctx.Svcs.FS
logger := hctx.Svcs.Log
logger.Infof("Dataset create started for format: %v, id: %v", req.Id, req.Format)
logger.Infof("Dataset create started for format: %v, id: %v", req.Format, req.Id)

// Validate the dataset ID - can't contain funny characters because it ends up as an S3 path
// NOTE: we also turn space to _ here! Having spaces in the path broke quants because the
Expand All @@ -325,7 +325,7 @@ func HandleScanUploadReq(req *protos.ScanUploadReq, hctx wsHelpers.HandlerContex
s3PathStart := path.Join(filepaths.DatasetUploadRoot, datasetID)

// Append a few random chars to make it more unique from this point on
datasetID += "_" + utils.RandStringBytesMaskImpr(6)
//datasetID += "_" + utils.RandStringBytesMaskImpr(6)

// We don't need to check anything beyond does this file exist?
/*
Expand Down

0 comments on commit 4fd782d

Please sign in to comment.