-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test numpy==2.0.0rc2 #3535
base: develop
Are you sure you want to change the base?
test numpy==2.0.0rc2 #3535
Conversation
Looks like some parts of the numpy API we were using aren't around anymore:
I don't see "subarray" as member in the docs, either. |
@gojomo Please continue to look into this. I'm removing it from the upcoming milestone, just to get things out the door quicker. |
@mpenkov I'll be tinkering, but it'll be a few minutes here and there, so unsure I'll even have a good sense of the magnitude of required changes anytime soon. I suspect the numpy release will cause hiccups & scrambles across the Python data/ML ecosystem. So, my hunch remains: next Gensim fix release should just require numpy<2.0.0, to minimize immediate problems when it arrives, pending further work. |
@gojomo numpy 2.0 stable was released yesterday |
Yes, as expected & mentioned above. |
What is the expected timeline for numpy 2.x support? |
So far I've not seen much discussion or estimation of the effort required, or anyone stepping up to take the lead – so AFAICT, timeline uncertain. |
Bump, this is now starting to conflict with the rest of the environment where other packages have moved on |
@mpenkov If it is fine by you guys; I will work towards numpy 2.0 / 2.1 support. |
@hechth @YoungMind1 is there some progress on this? I'd also be interested in that and would potentially be able to contribute. |
@hechth I am getting cython / ABI related errors for now, trying to pin down the exact problem... |
@YoungMind1 Any news? :) Would also be happy to help out 🫡 |
Test what happens to our builds if
numpy==2.0.0rc2
is specified, as Numpy 2.0 release is expected on June 16 and there may be breaking changes that torpedo our currentnumpy >= 1.18.5
dependency.