-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use documented synch APIs #37
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I rebuilt the change on a new device and noticed that test-reflock does not pass anymore. I'll investigate my changes further. |
Thanks @rzhao271 for creating this PR. |
I have switched to using condition variables and added another bitflag, giving the following advantages:
|
Downstream PR: zeromq/libzmq#4680
This PR would help Microsoft repositories indirectly consuming and rebuilding wepoll, such as microsoft/zeromq-prebuilt, to get into compliance with internal policies by using APIs only documented on learn.microsoft.com.
However, this PR also brings in a dependency on synchronization.lib, which raises the minimum required Windows version to Windows 8.This PR uses condition variables, bringing the minimum required Windows version to Windows Vista.
Older version of this PR that was for the dist branch: #36