-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support gbk charset #808
base: master
Are you sure you want to change the base?
support gbk charset #808
Conversation
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 78.35% 78.27% -0.09%
==========================================
Files 40 40
Lines 14773 14707 -66
==========================================
- Hits 11576 11512 -64
- Misses 2509 2515 +6
+ Partials 688 680 -8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
Why do we support GBK rather than its superset GB18030?
Co-Authored-By: kennytm <[email protected]>
@kennytm Because we just met |
PTAL @bb7133 @wjhuang2016 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetSupportedCharsets
need to change too.
@wjhuang2016 PTAL :) |
@spongedu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
We're using parser to develop some our systems and found that charset gbk is not supported yet in parser, which makes some SQL fail to work.
As a MySQL compatible parser, I think we should support gbk as MySQL's parser do, and leave the charset-compatible issues to
TiDB
layer.What is changed and how it works?
Add gbk into supported charsets, and add related tests
Check List
Tests