[Edit lock] Check for edit lock when editing data, not when opening element #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
|
I have read the CLA Document and I hereby sign the CLA |
|
@fashxp how will it be done in the new studio ui? Conceptual it sounds good to me. |
|
not finally decided yet. but we have a concept to get notified about remote changes and what you want to do about them. so that edit lock might not be necessary at all anymore. this change needs to be tested carefully though. maybe someone from the community can help us there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when 2 users open the same element, there is this warning:
This confuses users because this even happens if they only want to look up things without changing anything. For this reason this PR changes the behaviour so that the edit lock does not get checked when opening an element but when editing it. As soon as any data of the element gets changed and thus the element gets
dirty, the edit lock will get checked. The message in the popup window has been adjusted a bit:When the user chooses to continue editing (= clicks "Yes"), the edit lock will get released.
When the user clicks "No", the element will get closed and reopened.