Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let data writer distinguish between m and g as product dimensions #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Merjo
Copy link
Contributor

@Merjo Merjo commented Oct 2, 2024

No description provided.

@JakobBD JakobBD self-requested a review October 2, 2024 12:23
Copy link
Collaborator

@JakobBD JakobBD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to blindly approve this. The function urgently needs refactoring, which will remove the need for this. I don't object to having whatever in the meantime.

@Merjo
Copy link
Contributor Author

Merjo commented Oct 2, 2024

Thank you - I was thinking as well that a refactoring would be good, right now the sankey diagram just shows the results for the CAZ region in 2050, and it would be good if this could be parameterized in the config or something, ideally with also the option to sum over the regions to get a total world figure. I'm prioritizing other things right now but could propose an implementation if needed as well.

@Merjo
Copy link
Contributor Author

Merjo commented Oct 2, 2024

What is our protocol on merging pull requests after one person has approved them? Can I just go ahead or should we wait for everybody to approve? Just new to Git :)

@SallyDa
Copy link
Collaborator

SallyDa commented Oct 2, 2024

You can go ahead and merge after one approving review. We decided to do it like this for now, and later we can review and see if everyone is happy with this approach.

@JakobBD
Copy link
Collaborator

JakobBD commented Oct 2, 2024

I've added a git page on this, to have a common understanding: https://github.com/pik-piam/sodym/wiki/Git-protocol
Feel free to make/propose changes, but inform the others (e.g. on mattermost)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants