Small changes to DimensionSet #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame dimensions to dim_list
SallyDa
reviewed
Sep 20, 2024
|
Will adapt simson, but not the notebooks before #33 is merged. I propose this order:
Okay? |
|
Update: Simson does not appear to need updates. |
|
In general I am not a fan of merging stuff that breaks other functionality, but since you are working on the notebooks separately, then yes, we can do this. |
SallyDa
approved these changes
Sep 24, 2024
|
Ah no, I meant to do this all before merging this PR :-) |
|
adapted notebooks, fixed merge bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move dimension set union and intersection to DimensionSet object; rename dimensions to dim_list