Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter IEA ETP production data using a custom aggregation function #537

Merged
merged 15 commits into from
Oct 1, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Sep 5, 2024

  • This PR uses a custom aggregation function to read in GLO data directly, rather than disaggregating and aggregating.
  • Besides, the regional disaggregations of the regions OECD and Non-OECD were dropped, because the disaggregated data relies heavily on the chosen weight and is not usable for comparison.
  • This results in some regions having less variables (because the values before were unreliable) and CHA having lover values than before (because it now equals CHN, with other CHA regions set to 0).
  • For details, see: https://cloud.pik-potsdam.de/index.php/f/22298897
  • This does not affect industry inputdata generation, as the corresponding functions calcFeDemandIndustry and calcSteel_Projections only use readIEA_ETP without the convert function and this portion has not been changed (only enhanced by World data)

@fbenke-pik fbenke-pik marked this pull request as ready for review September 5, 2024 09:49
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@fbenke-pik
Copy link
Contributor Author

fbenke-pik commented Sep 5, 2024

It is basically the madrat-way to achieve what this. I was only not aware that it exists before.

@fbenke-pik fbenke-pik merged commit 9a60830 into pik-piam:master Oct 1, 2024
2 checks passed
@fbenke-pik fbenke-pik deleted the warnings branch October 1, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants