-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read in latest IEA data as reference data #469
Conversation
@@ -28,7 +27,7 @@ calcFE <- function(source = "IEA", scenario_proj = "SSP2") { | |||
colnames(map) <- gsub("io", "names_in", colnames(map)) | |||
|
|||
# Give description | |||
descript <- "IEA Final Energy Data based on 2017 version of IEA Energy Balances" | |||
descript <- "IEA Final Energy Data based on 2022 version of IEA Energy Balances" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only true for *_latest IEA data, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it is true for the current default, i.e the description is accurate for inputdata generation. latest would be 2023. i decided not to make it conditional (to avoid another if-clause that adds little value) in all places where we add a description and accept that the description is inaccurate when using it solely for generating the historical.mif.
) %>% | ||
unite('text', c('product', 'flow'), sep = '.') %>% | ||
pull('text') | ||
unite("text", c("product", "flow"), sep = ".") %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all cleaning!
@@ -225,5 +237,5 @@ calcIO <- function(subtype = c("input", "output", "output_biomass", "trade", | |||
} | |||
|
|||
return(list(x = reminditems, weight = NULL, unit = "EJ", | |||
description = "IEA SE Output Data based on 2017 edition of IEA World Energy Balances")) | |||
description = "IEA SE Output Data based on 2022 edition of IEA World Energy Balances")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be different when we will update the latest version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see me comment above. this is accurate for the default, aka the inputdata generation. when we update to latest version, we will have to update here, too (and in many other places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o.k., hope we will remember
Add includes structures to read out latest IEA data to be included in historical mif without updating IEA data for input data generation.
Depends on pik-piam/mrcommons#107