-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read in corrected IEA_ETP notebooks #456
Conversation
Two points:
I would therefore opt to add a parameter to |
According to Lavinia you can simply rename the generated files, if the additional hash in the names is the only problem. |
Sure. "Rename some files manually" is a cherished component of any reproducible science workflow … |
I was just proposing renaming the specific output file as a quick fix so we don't have to start inputdata generation again. |
On it |
Looks like readSource does not accept custom parameters (e.g. version). So if we wanted to make the version part of the input params, it would have to be via subtypes. This would blow up subtype values from 4 to 8 (4 subtypes x 2 version numbers).
If this is the only concern, there are other ways to ensure backwards compatibility. I adjusted the structure of the source file on the cluster so that older versions of mrremind read the faulty data and this takes the new data (v1.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked REMIND v3.2.1.dev902
with input data 6.68-A
(dev) and 6.68-B
(ETPfix) and the results match what was expected.
compScen-dev_ETPfix-2024-02-04_21.33.19-H12.pdf
Here is the code used for the test, updated to |
Ah sorry, I missed that. |
No description provided.