allow filtering for years when creating historical.mif #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +13,7 @@ | |||
| #' fullREMIND() | |||
| #' } | |||
| #' | |||
| fullREMIND <- function(rev = 0) { | |||
There was a problem hiding this comment.
did this rev argument has any functionality in retrieveData, which we are only not using?
There was a problem hiding this comment.
Nothing I can see. rev is an input parameter to retrieveData and is therefore set in our inputdata generation, but it does have to be passed to the full functions, unless you want to use it there. As we do not use it here, I deleted it.
Running input data generation without it went through as expected.
| #' @seealso | ||
| #' \code{\link{fullREMIND}},\code{\link{readSource}},\code{\link{getCalculations}},\code{\link{calcOutput}} | ||
| #' @examples | ||
| #' \dontrun{ | ||
| #' fullVALIDATIONREMIND() | ||
| #' } | ||
| #' | ||
| fullVALIDATIONREMIND <- function(rev = 0) { | ||
| fullVALIDATIONREMIND <- function(years = NULL) { |
LaviniaBaumstark
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to restrict the years when generating the historical.mif, so we don't need to get all the years starting from the 1700s