Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate SE variables for IEA #443

Closed
wants to merge 2 commits into from
Closed

Conversation

fbenke-pik
Copy link
Contributor

No description provided.

+ x[, , "SE|Gases|Fossil|Coal (EJ/yr)"]
+ x[, , "SE|Gases|Fossil|Natural Gas (EJ/yr)"], "SE|Gases (EJ/yr)"))

x <- mbind(x, setNames(x[, , "SE|Liquids|Bio Oil (EJ/yr)"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use the variable SE|Liquids|Biomass? Is SE|Liquids|Bio Oil equal to SE|Liquids|Biomass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getNames(x[, , "SE|Liquids", pmatch=T]) yields
"SE|Liquids|Bio Oil (EJ/yr)" "SE|Liquids|Fossil|Gas (EJ/yr)" "SE|Liquids|Fossil|Oil (EJ/yr)"

SE|Liquids|Biomass seems to be not available in this context (uses structuremappingIO_reporting.csv)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually what got me started again with the structuremappings....
https://github.com/remindmodel/development_issues/issues/83#issuecomment-1801368318

I don't think this is an output that is produced from structuremappingIO_reporting, and before changing that I want to make sure it builds up from the right structuremapping...

@Renato-Rodrigues
Copy link
Member

Renato-Rodrigues commented Nov 8, 2023

could you also check/add these additional variables together with this PR?

SE|Gases|Fossil = SE|Gases|Fossil|Coal + SE|Gases|Fossil|Natural Gas
SE|Heat|Fossil = SE|Heat|Coal + SE|Heat|Gas
SE|Liquids|Fossil = SE|Liquids|Fossil|Gas + SE|Liquids|Fossil|Oil
SE|Solids|Fossil = SE|Solids|Coal (<- I am not sure about this one just from memory if it also needs to include some waste term)
SE|Electricity|Fossil = SE|Electricity|Coal + SE|Electricity|Gas + SE|Electricity|Oil or SE|Electricity|Fossil|w/ CC = SE|Electricity|Fossil|w/ CC + SE|Electricity|Fossil|w/o CC

@robertpietzcker
Copy link
Contributor

could you also check/add these additional variables together with this PR?

SE|Gases|Fossil = SE|Gases|Fossil|Coal + SE|Gases|Fossil|Natural Gas SE|Heat|Fossil = SE|Heat|Coal + SE|Heat|Gas SE|Liquids|Fossil = SE|Liquids|Fossil|Gas + SE|Liquids|Fossil|Oil SE|Solids|Fossil = SE|Solids|Coal (<- I am not sure about this one just from memory if it also needs to include some waste term) SE|Electricity|Fossil = SE|Electricity|Coal + SE|Electricity|Gas + SE|Electricity|Oil or SE|Electricity|Fossil|w/ CC = SE|Electricity|Fossil|w/ CC + SE|Electricity|Fossil|w/o CC

actually, I think it has to be
SE|Heat|Fossil = SE|Heat|Coal + SE|Heat|Gas + SE|Heat|Oil
SE|Liquids|Fossil = SE|Liquids|Fossil|Gas + SE|Liquids|Fossil|Oil + SE|Liquids|Coal

@fbenke-pik
Copy link
Contributor Author

SE|Liquids|Coal and SE|Heat|Oil cannot be found in the source

@fbenke-pik
Copy link
Contributor Author

fbenke-pik commented Nov 8, 2023

Just agreed with Robert that we will first look into unifying / fixing the structure mappings (see https://github.com/remindmodel/development_issues/issues/83) before moving forward with this.

@fbenke-pik fbenke-pik marked this pull request as draft November 8, 2023 16:11
@fbenke-pik fbenke-pik closed this Feb 7, 2024
@fbenke-pik fbenke-pik deleted the iea branch February 7, 2024 16:26
@fbenke-pik fbenke-pik restored the iea branch February 7, 2024 16:26
@fbenke-pik fbenke-pik deleted the iea branch February 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants