Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: only read specified buildings scenarios #417

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

robinhasse
Copy link
Contributor

The filtering of specified scenarios when reading demands of buildings did not cover energy services and floor space. This can lead to an Error if the source data includes scenarios not yet considered in the code. I fixed this bug and did a minor clean up of the code in this course.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e3f32f5) 0.00% compared to head (f568d1b) 0.00%.

❗ Current head f568d1b differs from pull request most recent head 43c39b0. Consider uploading reports for the commit 43c39b0 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #417   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         265     265           
  Lines       17271   17266    -5     
======================================
  Hits            1       1           
+ Misses      17270   17265    -5     
Files Changed Coverage Δ
R/readEDGE.R 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinhasse robinhasse merged commit 31573be into pik-piam:master Aug 15, 2023
1 check passed
@robinhasse robinhasse deleted the buildScenFix branch August 15, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants