Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add H2 space heating #27

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Add H2 space heating #27

merged 1 commit into from
Aug 12, 2024

Conversation

robinhasse
Copy link
Contributor

  • Add space heating with H2
  • overhaul investment cost calculation
    • higher fix costs (independent of capacity) for installation work
    • benefit for identical replacement (sameAs factor) now only applies to the fixed installation cost but is much stronger
    • higher capacity assumption
    • mredgebuildings now considers the technology mapping from BRICK for the selection of heating systems.
  • Bugfix: zero cost for no action

@robinhasse robinhasse added bug Something isn't working enhancement New feature or request labels Aug 12, 2024
@robinhasse robinhasse mentioned this pull request Aug 12, 2024
Merged
ricardarosemann
ricardarosemann approved these changes Aug 12, 2024
View reviewed changes
Copy link

@ricardarosemann ricardarosemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks also for this!

I have a few minor comments, which you can safely ignore, if you wish.

R/calcCarrierPrices.R Outdated Show resolved Hide resolved
R/calcHeatingSystem.R Outdated Show resolved Hide resolved
R/calcHeatingSystem.R Outdated Show resolved Hide resolved
R/calcLifetimeParams.R Show resolved Hide resolved
R/calcCarrierPrices.R Show resolved Hide resolved
@robinhasse robinhasse merged commit 8aff157 into pik-piam:main Aug 12, 2024
2 checks passed
@robinhasse robinhasse deleted the addH2 branch August 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardarosemann ricardarosemann ricardarosemann approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinhasse @ricardarosemann