Refactor and change default scenarios #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop SSP2EU scenario. Add ADB sources and scenarios. Urban pop share scenarios are improved, so as to never exceed 1, even with bezier extensions. SSP labour scenarios are now also filled in with UN_popDiv data. Fixes pik-piam#13. Deprecate scenario.indicator naming. Fix all linter warnings. Fixes pik-piam#56 and fixes pik-piam#57. Improve and simplify documentation. Fixes pik-piam#16.
|
Hey @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q. I would like to close issues #56 and #57 with this PR. Would you take a look and let me know if you agree? The references are here, and this vignette is linked to in the descriptions of the calc functions, and also available on the website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop SSP2EU scenario.
Add ADB sources and scenarios (not as default yet).
Urban pop share scenarios are improved, to never exceed 1, even with bezier extensions.
SSP labour scenarios are now also filled in with UN_popDiv data.
Fixes #13.
Deprecate option "scenario.indicator" for the naming argument.
Fix all linter warnings.
Fixes #56 and fixes #57.
Improve and simplify documentation. Fixes #16.