Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for write.report #161

Merged
merged 1 commit into from
Nov 13, 2023
Merged

add test for write.report #161

merged 1 commit into from
Nov 13, 2023

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Nov 10, 2023 •
edited
Loading

Looks like #160 moved code coverage below a critical threshold.
I added a test for my bugfix here. Jan, how can I test if coverage requirements are met before merging?

tscheypidi
tscheypidi approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the test. With covr::code_coverage() you can test the coverage locally. For our core packages such as magclass and madrat it is recommended to cover have all touched lines of code in PR covered by a test.

@fbenke-pik fbenke-pik merged commit f4828b7 into pik-piam:master Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscheypidi tscheypidi tscheypidi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbenke-pik @tscheypidi