Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacol in as.magpie accepts colname of data.frame #155

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

robinhasse
Copy link
Contributor

I found it inconsistent that as.magpie() for data.frames accepts character column names for temporal and spatial but not for datacol. With this PR, you can now also pass a character object as datacol in as.magpie() for data.frames.

Copy link
Contributor

@pfuehrlich-pik pfuehrlich-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@robinhasse robinhasse merged commit 9a06c8b into pik-piam:master Aug 7, 2023
1 check passed
@robinhasse robinhasse deleted the characterDatacol branch August 7, 2023 11:58
Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants