Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tool function #206

Closed
wants to merge 1 commit into from

Conversation

johanneskoch94
Copy link
Member

The idea here is to create a central parameter/function with which we control/set the monetary unit, throughout the magpie/remind pre-processing.
In effect, the crucial part is the monetary unit's base year (our choice of currency, the $, in PPP or MER, not really being up for debate).

Ideally, this function will be called every time monetary values are converted, providing the unit in which the values are to be converted to. The conversion process itself should rely on GDPuc::convertGDP (since this function/package will be used for all monetary conversions, the naming should perhaps be revised...). To make the whole process as easy as possible, the proposed function, here called toolGetUnitDollar, would ideally return the exact string that can be passed to GDPuc::convertGDP's unit_out argument.

Questions:

  • Is this package the right place to introduce a function like this?
  • Should we take this opportunity and create the framework for a more general toolGetUnit function?
  • Where should the units be defined? In this case, the base year is defined within the tool function itself. Perhaps a special, external file should be used instead? Where all units are defined?

@johanneskoch94
Copy link
Member Author

Another point: we would of course have to agree on a unique formulation for the unit of monetary values. No more 2005$, 05$, 2005 US$, US$05, US$ 2005, constant 2005US$, USD05, 2005 Int$, and so on.... Perhaps a choice was already made in piamInterfaces that we could take over? Otherwise, the formulation accepted by GDPuc, i.e. "constant 2017 Int$PPP" or "constant 2017 US$MER", could be used. It wouldn't be the most concise way of putting it, but the most explicit, avoiding any possible confusion...

@tscheypidi
Copy link
Member

this is too application specific to be put in madrat. I guess mrdrivers could be a better spot

@LaviniaBaumstark
Copy link
Member

If this function only defines teh dollar unit, I agree with JPD and would put it in mrdrivers. Let's stat with this. Maybe later we will decide to implement a more general default-unit-function for madrat and can use this dollar-function as a starting point.

@LaviniaBaumstark
Copy link
Member

Another point: we would of course have to agree on a unique formulation for the unit of monetary values. No more 2005$, 05$, 2005 US$, US$05, US$ 2005, constant 2005US$, USD05, 2005 Int$, and so on.... Perhaps a choice was already made in piamInterfaces that we could take over? Otherwise, the formulation accepted by GDPuc, i.e. "constant 2017 Int$PPP" or "constant 2017 US$MER", could be used. It wouldn't be the most concise way of putting it, but the most explicit, avoiding any possible confusion...

@orichters @fbenke-pik do you know a good standard from piamInterfaces?

@orichters
Copy link
Contributor

REMIND uses US$2010 quite consistently, whereas MAgPIE had some more variety, but already consolidated a bit since I told them about it. But piamInterfaces basically treats all those versions as mutually identical, and we could easily add a new version if needed. The new community standard will probably be billion USD_2010/yr to avoid issues with the special character $. Not sure whether PPP and MER should be part of the unit, but maybe it is helpful.

@fbenke-pik
Copy link
Contributor

Closed in favour of pik-piam/mrdrivers#86

@fbenke-pik fbenke-pik closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants