added tools for cache persistent status messages #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' 2) messages are always stored in lists with messages split by function calls | ||
| #' where the message was triggered. | ||
| #' | ||
| #' @param name The category in which the message should be stored |
There was a problem hiding this comment.
What categories do you mean here? The example puts "test" here, but I'm still not sure how to use this. It is an arbitrary string chosen by the user?
R/getMadratMessage.R
Outdated
| @@ -0,0 +1,31 @@ | |||
| #' Tool: getMadratMessage | |||
There was a problem hiding this comment.
This makes me think it is a function with the "tool" prefix, but it is not. So maybe delete the "Tool: " here?
Suggested change
| #' Tool: getMadratMessage | |
| #' getMadratMessage |
| @@ -55,6 +55,7 @@ cacheGet <- function(prefix, type, args = NULL, graph = NULL, ...) { | |||
| x[[elem]] <- .terraLoad(x[[elem]]) | |||
| } | |||
| } | |||
| putMadratMessage(value = attr(x, "madratMessage")) | |||
There was a problem hiding this comment.
I would have expected that the message is also printed here, is there a reason why not?
There was a problem hiding this comment.
well, with this procedure you can store various types of information. For some you might want to have them reported at some point for others you might not. As it is unclear what should happen with this information I would not print it here.
pfuehrlich-pik
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added getMadratMessage, putMadratMessage and resetMadratMessages for cache persistent status messages