Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some type issues, there are probably more so I'll make another PR soon #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eiiot
Copy link

@eiiot eiiot commented Apr 7, 2022

No description provided.

@eiiot
Copy link
Author

eiiot commented Apr 7, 2022

I put a lot of time and effort into this PR

@eiiot
Copy link
Author

eiiot commented Apr 7, 2022

I also fixed FetchAllTrains, it returns { [key: number]: trainData[] } not trainData[]

@piemadd
Copy link
Owner

piemadd commented Apr 8, 2022

TBH the solution to the dates shouldn't be to change the type to a string, but to ensure it is a Date before being returned.

@eiiot
Copy link
Author

eiiot commented Apr 8, 2022

I've found that new Date doesn't really like this format for some reason, though

@piemadd
Copy link
Owner

piemadd commented Apr 8, 2022 via email

@eiiot
Copy link
Author

eiiot commented Apr 8, 2022

Wait that was an error w/ another api nevermind :)

@piemadd
Copy link
Owner

piemadd commented Apr 8, 2022

mf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants