Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 #258

Merged
merged 9 commits into from
Oct 20, 2023
Merged

v1 #258

merged 9 commits into from
Oct 20, 2023

Conversation

dantownsend
Copy link
Member

No description provided.

sinisaos and others added 9 commits September 4, 2023 13:46
* pydantic_v2_support

* pin to Piccolo v1

* add comment

* remove KeyError Exception

* upgrade coverage

* fix type warnings with `nested`

* fix mypy warnings

* update black

* replacement for `outer_type`

* change assertion

---------

Co-authored-by: Daniel Townsend <[email protected]>
* fix `_get_type` - check for `NoneType`

* add tests

* fix typo

* add a test for the new union syntax

* also check for `UnionType`
@dantownsend dantownsend added the enhancement New feature or request label Oct 20, 2023
@dantownsend dantownsend changed the title V1 v1 Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #258 (76ab240) into master (6031dbb) will increase coverage by 0.19%.
The diff coverage is 88.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   92.50%   92.69%   +0.19%     
==========================================
  Files          33       33              
  Lines        2027     2039      +12     
==========================================
+ Hits         1875     1890      +15     
+ Misses        152      149       -3     
Files Coverage Δ
piccolo_api/__init__.py 100.00% <100.00%> (ø)
piccolo_api/crud/endpoints.py 95.75% <100.00%> (+0.79%) ⬆️
piccolo_api/crud/serializers.py 100.00% <100.00%> (ø)
piccolo_api/crud/validators.py 90.38% <100.00%> (ø)
piccolo_api/media/local.py 100.00% <100.00%> (ø)
piccolo_api/media/s3.py 99.10% <100.00%> (ø)
piccolo_api/shared/auth/junction.py 42.85% <ø> (ø)
piccolo_api/token_auth/endpoints.py 88.57% <ø> (ø)
piccolo_api/shared/middleware/junction.py 0.00% <0.00%> (ø)
piccolo_api/fastapi/endpoints.py 97.12% <82.35%> (-2.08%) ⬇️

@dantownsend dantownsend merged commit 3ae09ac into master Oct 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants