-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project management endpoints #1442
Conversation
CHANGELOG entry requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if in the future we will want to allow users to update any of their prefs, or at least some select ones.
The main one I could see is policy. e.g. cat my-policy.rego | xargs phylum project update --policy
(syntax?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding off on this PR until the default label can be changed through the /data/projects/{project_id}
.
Stalled due to https://github.com/phylum-dev/api/issues/1390. |
Stalled due to https://github.com/phylum-dev/api/pull/1559. |
This patch updates the endpoints used for the project management subcommands to avoid the soon-to-be deprecated overview endpoint. The `phylum project update` subcommand has been updated to make use of the new `default_label` field, which can now be updated. The `phylum project list` subcommand now lists all projects by default, including group projects. To still allow listing only non-group projects the new `--no-group` flag has been added to this subcommand specifically. The `repository_url` has been removed from the command output, since it is not included in the API response. The group name has been removed from `phylum project status`, since the new endpoint used by the subcommand does not return this information. However the `default_label` field was added instead. Closes #1439.
Tested locally against the latest staging API and everything seems to be working as I intended now. |
This patch updates the endpoints used for the project management
subcommands to avoid the soon-to-be deprecated overview endpoint.
The
phylum project update
subcommand has been updated to make use ofthe new
default_label
field, which can now be updated.The
phylum project list
subcommand now lists all projects by default,including group projects. To still allow listing only non-group projects
the new
--no-group
flag has been added to this subcommandspecifically. The
repository_url
has been removed from the commandoutput, since it is not included in the API response.
The group name has been removed from
phylum project status
, since thenew endpoint used by the subcommand does not return this information.
However the
default_label
field was added instead.Closes #1439.