Update project management endpoints #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CHANGELOG entry requested. |
mathew-horner
previously approved these changes
Jun 10, 2024
cd-work
commented
Jun 11, 2024
|
Stalled due to https://github.com/phylum-dev/api/issues/1390. |
cd-work
changed the title
|
Stalled due to https://github.com/phylum-dev/api/pull/1559. |
This patch updates the endpoints used for the project management subcommands to avoid the soon-to-be deprecated overview endpoint. The `phylum project update` subcommand has been updated to make use of the new `default_label` field, which can now be updated. The `phylum project list` subcommand now lists all projects by default, including group projects. To still allow listing only non-group projects the new `--no-group` flag has been added to this subcommand specifically. The `repository_url` has been removed from the command output, since it is not included in the API response. The group name has been removed from `phylum project status`, since the new endpoint used by the subcommand does not return this information. However the `default_label` field was added instead. Closes #1439.
|
Tested locally against the latest staging API and everything seems to be working as I intended now. |
mathew-horner
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the endpoints used for the project management
subcommands to avoid the soon-to-be deprecated overview endpoint.
The
phylum project updatesubcommand has been updated to make use ofthe new
default_labelfield, which can now be updated.The
phylum project listsubcommand now lists all projects by default,including group projects. To still allow listing only non-group projects
the new
--no-groupflag has been added to this subcommandspecifically. The
repository_urlhas been removed from the commandoutput, since it is not included in the API response.
The group name has been removed from
phylum project status, since thenew endpoint used by the subcommand does not return this information.
However the
default_labelfield was added instead.Closes #1439.