get_defined_vars() return type contains know variables

[MartinMystikJonas]

Solves phpstan/phpstan#11948
Solves phpstan/phpstan#11740

Credits to @ruudk

[ruudk]

When escaping single quotes, I always (when possible) switch to double quoted string to prevent that.

• easier on the eyes
• easier to copy and paste
• easier to search for the unescaped string in the codebase

Suggested change

	assertType('array{param: int, local: \'foo\'}', get_defined_vars());
	assertType('array{\'param\', \'local\'}', array_keys(get_defined_vars()));
	assertType("array{param: int, local: 'foo'}", get_defined_vars());
	assertType("array{'param', 'local'}", array_keys(get_defined_vars()));

[MartinMystikJonas]

I do that too but I checked how it is done in other parts of PHPStan and found out that escaping seems to be standard here.

[herndlm]

I also often do the double quote. but I think in general it's very inconsistent :D not sure if such thing exists, but a coding standard rule might be good for this 😊
UPDATE: on the other hand - in those tests files it wouldn't be enforced anyway I guess..

[ruudk]

We use https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#symplifyquoteescaperector and it works good

[staabm]

(the unrelated lint build errors will be fixed after rebase; please remove the merge commit)

[MartinMystikJonas]

@staabm Removed merge commit. Should be ready to merge - two failing checks are unrelated.

[staabm]

the "Lint / Coding Standard (pull_request) " fail is related to the PR. just run make cs-fix locally and commit the fix

[MartinMystikJonas]

CS fixed

[ondrejmirtes]

Also it might be useful to still do it on 1.12.x instead?

[ondrejmirtes]

Use ConstantArrayTypeBuilder instead.