-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ArrayChangeKeyCaseFunctionReturnTypeExtension #3549
Open
VincentLanglet
wants to merge
5
commits into
phpstan:1.12.x
Choose a base branch
from
VincentLanglet:arrayChangeKeyCase
base: 1.12.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
arrayChangeKeyCase
branch
2 times, most recently
from
October 7, 2024 19:48
615c172
to
461b22d
Compare
VincentLanglet
commented
Oct 7, 2024
VincentLanglet
force-pushed
the
arrayChangeKeyCase
branch
3 times, most recently
from
October 7, 2024 21:35
8f5fde7
to
61bdd79
Compare
This pull request has been marked as ready for review. |
staabm
reviewed
Oct 8, 2024
staabm
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks
VincentLanglet
force-pushed
the
arrayChangeKeyCase
branch
from
November 10, 2024 18:41
cdfc170
to
cdbbbb5
Compare
Friendly ping @ondrejmirtes if you have time. This might be interesting to be merged to be updated in the uppercase-string PR #3613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11795
Closes phpstan/phpstan#10960
cc @staabm