Update ComponentModel\Container stub for component-model 3.1.0 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
cm-container-3.1
branch
2 times, most recently
from
ed45fb8
to
11e9969
Compare
There is no |
|
Looks like this is recognized properly, as I no longer get 173 Parameter ＃1 $array of function array_filter expects array, Iterator<int|string, Nette\ComponentModel\IComponent> given. But for some reason it now thinks it returns the union of both branches: 173 Parameter ＃1 $array of function array_filter expects array, array<int|string, Nette\ComponentModel\IComponent>|Iterator<int|string, Nette\ComponentModel\IComponent> given. (This is with PHPStan 1.11.1.) |
That version changes the return type to array when `$deep` argument is `false` (default): nette/component-model@7f613ee It also deprecates the arguments but we cannot add deprecated annotation to those. nette/component-model@4e0946a
|
I tried to reproduce it in Playground but it does not fail there: https://phpstan.org/r/50c723fc-6a84-4ca3-945d-fdc4fc5f9fbc Possibly this is some difference in how stubs are handled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That version changes the return type to array when
$deepargument isfalse(default):nette/component-model@7f613ee
It also deprecates the arguments but we cannot add deprecated annotation to those.
nette/component-model@4e0946a