Parse SRID in column definition #595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
reviewed
Nov 2, 2024
| @@ -0,0 +1,7 @@ | |||
| CREATE TABLE IF NOT EXISTS `public_areas` ( | |||
There was a problem hiding this comment.
Are we not missing a line in the test file for the test to pick up this file?
There was a problem hiding this comment.
Is picked up automatically:
sql-parser/src/Tools/TestGenerator.php
Line 234 in 9851579
There was a problem hiding this comment.
You are right, only the generation of the out file is picked up automatically. I added the missing line.
MoonE
force-pushed
the
srid-in-column-definition
branch
from
8e12200
to
705d0b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpmyadmin/phpmyadmin#18513
The parsing does not consider the db version and MariaDB does not support this.