Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish translation of PHP 8.4 Announcement Page #1159

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

emir
Copy link
Contributor

@emir emir commented Nov 22, 2024

👋👋

@emir
Copy link
Contributor Author

emir commented Nov 22, 2024

@saundefined This isn’t the topic of this PR, but we could also sort the languages alphabetically in common.php. What do you think?

@saundefined
Copy link
Member

@saundefined This isn’t the topic of this PR, but we could also sort the languages alphabetically in common.php. What do you think?

It could be done, but I don't think it would be especially helpful...

Many languages do not use Latin, and correct sorting is probably possible only by keys,
and also the page tries to guess the user's language and show him the right version at once

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit 4eec6ff into php:master Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants