feat: CI job for building Docker binary-only images #122
Conversation
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . | ||
| platforms: linux/amd64,linux/arm64 |
There was a problem hiding this comment.
Is there a way we can build this architecture-agnostic (rather than explicitly building for arm64/amd64/etc) 🤔
There was a problem hiding this comment.
As pointed out here, we can't do it (or at least I don't know how). Is it a problem, though?
There was a problem hiding this comment.
I was hoping you could build for noarch architecture or something to indicate that a single manifest can operate on any platform, since the only content of the image (the PHAR) is entirely platform agnostic. Not a major problem, but it creates overhead for something that should otherwise be a single step >.<
There was a problem hiding this comment.
Sadly, I believe it's not possible.
Wirone
force-pushed
the
codito/docker-builds
branch
from
566be9b
to
ab320ff
Compare
Wirone
force-pushed
the
codito/docker-builds
branch
from
76493bf
to
7eb5264
Compare
There was a problem hiding this comment.
FYI: this is currently not much usable for local development, but if you plan to define Docker setup for working with the project, you just need to utilise multi-stage build (keep standalone-binary target for releases and add new one(s) for development).
asgrim
added
the
maintainer feedback needed
Similar to composer/docker#250 (more info), this PR introduces a CI process for releasing binary-only images for Pie 🥳!
You can see the result here, there is an image in my fork's Package Registry, built here.
Here's how the image looks like (
dive ghcr.io/wirone/php-pie:latest):PS: I decided to not verify GPG signature during build because we can trust our own workflow (we copy PHAR file built in previous stage), but also I had some problems with verification (GPG imported correctly, but verification failed). Users may verify the file on their own, if they want, using attached
pie.asc.