Add Homebrew TAP support #113
Draft
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
reviewed
Nov 19, 2024
| RELEASE_TAG=${GITHUB_REF/refs\/tags\//} | ||
| echo "RELEASE_TAG=$RELEASE_TAG" >> $GITHUB_ENV | ||
| - name: Update Homebrew formula | ||
| uses: mislav/bump-homebrew-formula-action@v3 |
There was a problem hiding this comment.
I don't really understand what this is for / what this is doing? I'm assuming something to do with brew, but it's something I'm unfamiliar with. Can you give me a TLDR? or point me to some docs to understand this process please?
| class PhpPie < Formula | ||
| desc "PIE - the PHP Installer for Extensions" | ||
| homepage "https://github.com/php/pie" | ||
| url "https://github.com/php/pie/releases/download/0.2.0/pie.phar" |
There was a problem hiding this comment.
We should not hard-code this, the release process should be automated, and this will definitely be forgotten if it is not automated :)
There was a problem hiding this comment.
Personally I went with making a separate repo for this, which would be expected to be written on by a bothttps://github.com/box-project/homebrew-box
There was a problem hiding this comment.
| formula-path: homebrew/Formula/php-pie.rb | ||
| homebrew-tap: php/pie | ||
| download-url: https://github.com/php/pie/releases/download/${{ env.RELEASE_TAG }}/pie.phar | ||
| commit-message: | |
There was a problem hiding this comment.
Is this making a commit to php/pie? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires adding a new secret to actions
ACCESS_TOKENwith "repo" & "workflow" scopes.