Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail configure for libxml 2 >= 2.13.0 #16873

Open
wants to merge 1 commit into
base: PHP-8.1
Choose a base branch
from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 20, 2024

While we should not make changes to a security branch to support new libxml2 versions, we should at least fail early to avoid confusion; see GH-16863.


Note that this is not supposed to be merged up, since the compatibility issues has been resolved for PHP-8.2.

cc @nielsdos

While we should not make changes to a security branch to support new
libxml2 versions, we should at least fail early to avoid confusion; see
phpGH-16863.
@nielsdos
Copy link
Member

nielsdos commented Nov 20, 2024

I agree with the idea, but:

  1. perhaps the compatibility fix should be backported anyway given that our macOS CI fails with this PR's approach.
  2. we already know that Alpine builds PHP 8.1 with old libxml, so suddenly configuration will fail for them, they'd have to patch this out. Similar situations may cause confusion for other distributors.

@cmb69
Copy link
Member Author

cmb69 commented Nov 20, 2024

  1. perhaps it should be backported anyway given that our macOS CI fails now.

I still don't think it is a good idea to use Homebrew for security branches; it may not even be the best option for stable branches, because they appear to be pretty aggressive with their updates. If you are reasonably sure that backporting 67259e4 is okay, I'm fine with that (not my decision anyway, though). But I expect further issues within the next year (besides that #16789 will not help as of May).

2. we already know that Alpine builds PHP 8.1 with old libxml, so suddenly configuration will fail for them, they'd have to patch this out. Similar situations may cause confusion for other distributors.

Fair point. (I assume you meant "new libxml" instead of "old libxml".)

I guess release managers should decide what we do. @patrickallaert, @ramsey, thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants