PHP-8.4: LDAP changes #4066
PHP-8.4: LDAP changes #4066
Conversation
There was a problem hiding this comment.
I don't understand the
ldap_connect()toldap_connect_wallet()part of UPGRADING
See https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#ldap_connect for full details. TL;DR: ldap_connect() should be used when built against OpenLDAP; ldap_connect_wallet() when built against Oracle LDAP (the latter is apparently broken anyway; see https://externals.io/message/125933).
nor do I see how
ldap_exop_sync()is seemingly "better" than the current version?
Can't say much about that, except that generally ext/ldap is in thorough need of some TLC.
| <listitem> | ||
| <para> | ||
| The extended operation request data. | ||
| May be NULL for some operations like <constant>LDAP_EXOP_WHO_AM_I</constant>, |
There was a problem hiding this comment.
| May be NULL for some operations like <constant>LDAP_EXOP_WHO_AM_I</constant>, | |
| May be &null; for some operations like <constant>LDAP_EXOP_WHO_AM_I</constant>, |
| <para> | ||
| The extended operation request data. | ||
| May be NULL for some operations like <constant>LDAP_EXOP_WHO_AM_I</constant>, | ||
| may also need to be BER encoded. |
There was a problem hiding this comment.
Maybe
| may also need to be BER encoded. | |
| may also need to be <acronym>BER</acronym> encoded. |
(means "Basic Encoding Rules" in this context; however, "Bit Error Rate" seems also pretty common, so there might be an acronym clash)
There was a problem hiding this comment.
BER seems to be LDAP specific no? Actually it is a standard known as X.690
| Will be filled with the response OID if provided, | ||
| usually equal to the request OID. |
There was a problem hiding this comment.
Maybe
| Will be filled with the response OID if provided, | |
| usually equal to the request OID. | |
| Will be filled with the response <acronym>OID</acronym> if provided, | |
| usually equal to the request <acronym>OID</acronym>. |
(means "Object Identifier")
I don't understand the
ldap_connect()toldap_connect_wallet()part of UPGRADING, nor do I see howldap_exop_sync()is seemingly "better" than the current version? The mess of a return type is just duplicated currently....