curl-multi-exec.xml Change the function purpose #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure I'm offering a better description, perhaps a formulation like `Run the connections of handles contained in the given cURL multi handle` would be better, or some similar. I was just a little confused by the words `sub-connections` (the explanation of which is not given, although it is clear that we are talking about the connections of descriptors contained in the multi-descriptor), and the `current` word... Current in relation to what?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure I'm offering a better description, perhaps a formulation like
Run the connections of handles contained in the given cURL multi handle [asynchronously]would be better, or some similar. I was just a little confused by the wordssub-connections(the explanation of which is not given, although it is clear that we are talking about the connections of descriptors contained in the multi-descriptor), and thecurrentword... current in relation to what, and multipleconnectionsfor athe current cURL handle(it sounds like a normal handle contains a lot of connections).And I also don't know if we should add a paragraph saying that the multi handle starts many connections at once, which can improve the performance of application