Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enablesslchecks.xml: updated sslChecks link in changelog #3884

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leonardolara
Copy link
Contributor

To be consistent with recent update in method description.

@leonardolara leonardolara marked this pull request as draft October 18, 2024 11:10
@leonardolara leonardolara marked this pull request as ready for review October 18, 2024 11:12
@cmb69
Copy link
Member

cmb69 commented Oct 18, 2024

Thank you! However, see php/phd#164 (comment).

@Girgias
Copy link
Member

Girgias commented Oct 20, 2024

I don't know how we could reasonably implement automatic linking for <parameter> as it would require somehow to specify the function/method of it?

However, maybe what we could do is <parameter><xref /></parameter> or <paremeter><olink></olink></paramter> for the linking?

EDIT: I forgot that we can use common linking attributes on <parameter>

@cmb69
Copy link
Member

cmb69 commented Oct 20, 2024

That is not a parameter, but rather a property of OAuth.

@Girgias
Copy link
Member

Girgias commented Oct 20, 2024

That is not a parameter, but rather a property of OAuth.

aaaaahhhh well that makes it simpler, but I also just edited my comment as I forgot common linking attributes exist

@cmb69
Copy link
Member

cmb69 commented Oct 20, 2024

Right. See php/phd#164 (comment) (includes a POC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants