PHPDoc comment in MessageOriginChat mislead to wrong getter getChat(). #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factory creates getter getSender_chat() because property name sender_chat in MessageOriginChat
|
It should be getSenderChat(). Could you adjust it accordingly, please? |
Factory creates getter getSenderChat() because property name sender_chat in MessageOriginChat
|
Oh Sorry, my bad. Too much python for today. Pushed getSenderChat() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory creates getter getSender_chat() because property name sender_chat in MessageOriginChat
Summary
Just simple quick fix because PHPDoc Comment was the same to MessageOriginChat and MessageOriginChannel but properties isn't