Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split API and engine #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Split API and engine #255

wants to merge 1 commit into from

Conversation

vlsi
Copy link
Contributor

@vlsi vlsi commented Jan 19, 2020

This is mostly moving files around, however, I extracted interface for SourceOfRandomness because its implementation depends on lots of internal classes.

fixes #254

@vlsi vlsi force-pushed the split-api branch 4 times, most recently from 2926fdc to 4c64747 Compare January 19, 2020 14:23
@vlsi vlsi mentioned this pull request Jan 19, 2020
Open
@lorenzleutgeb
Copy link

Would be great to land this since it would enable clean use with JUnit 5!

pholser
pholser approved these changes Jun 30, 2020
View reviewed changes
Copy link
Owner

@pholser pholser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with rolling this into the main line -- would you mind to resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pholser pholser pholser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split junit-quickcheck-core into -api, -junit4, and -junit5 artifacts
3 participants
@vlsi @lorenzleutgeb @pholser