Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for setting additional client args. #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dylan-stark
Copy link

Adds support for setting additional client args to address issue #44.

Essentially, I added a module-level client_args dictionary, similar to huggingface.api_key and .prompt_builder. A user can put headers, cookies, etc., in there. And the key-value pairs will get unpacked at call-time as additional keyword args.

Note that I left the (implicit) model and token args untouched. Perhaps it makes sense to do a little work to check whether those are in client_args ahead of the call.

Copy link

@rodrigomasiniai rodrigomasiniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following provides client args capability that was missing

Copy link

@omkar-334 omkar-334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this added functionality would be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants