Add Test Vault and Fix Unknown Color #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The Bug I tried to resolve is mentioned here: #29
For easier debugging, I added a Test Vault, with a Hot Reload Plugin that Allows for Easier and Visual Debugging of the Plugin.
(Loosely Oriented on the Way the Task Obsidian Plugin does it, as I found it really Helpful)
I included a Supernote File which Reproduces the Error, and one that does not.
(Note, the one which throws the Error has just another Template in the Background, which causes the Fail)
The Error Produced is in the Submodule: https://github.com/philips/supernote-typescript.
Starting the Discussion for Resolving the Issue there: philips/supernote-typescript#3
Note:
Changed the Submodule for Better Testing.
Change the Submodule Back, when you want to accept this PR.
Side Note:
Having Trouble getting this Repo to Build and Transferred to the Vault.
Mainly, Changes in the Submodule do not get reflected when build from the Root Repo.
Somebody more Experienced with Node should look at it.