Custom dictionary #34
Conversation
customDictionary.ts
Outdated
| // Replace text with custom dictionary entries | ||
| export function replaceTextWithCustomDictionary(text: string, customDictionary: CustomDictionarySettings['customDictionary']): string { | ||
| for (const entry of customDictionary) { | ||
| text = text.replace(new RegExp(entry.source, 'g'), entry.replace); |
There was a problem hiding this comment.
Hrm. I am curious of two things:
-
Might it be better to use the strategy here to avoid looping multiple times over the text?
-
Would it be better to use a word boundary
\bto ensure you don't replace things in the middle of words?
There was a problem hiding this comment.
@philips Thanks for feedback. I took your feedback use the faster matching strategy. Regarding the work boundary, I often use acronyms or special symbols in my notes that often get broken up as multiple words. To optimize for individual workflows, I added two options to each dictionary entry: case insensitive matching and word boundary matching.
There was a problem hiding this comment.
@philips, have you had a chance to test this? I've been using it on my fork for about a month without issues. It would be great to get this merged for others to use.
Adds a settings panel to configure a custom dictionary: #32.