Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search of element in SpCollectionListModel. #1681

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

demarey
Copy link
Collaborator

@demarey demarey commented Dec 13, 2024

It should use equality. Bug introduced in commit 3967790.
It has already been fixed in Pharo 13. see 1b48d5a and 23bc559

It should use equality. Bueg introduced in commit 3967790.
It has already been fixed in Pharo 13. see pharo-spec@1b48d5a and pharo-spec@23bc559
@demarey
Copy link
Collaborator Author

demarey commented Dec 17, 2024

Fixes #1683

Copy link
Member

@estebanlm estebanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you need to dix the iceberg problem yet ;)

@demarey
Copy link
Collaborator Author

demarey commented Dec 18, 2024

but you need to dix the iceberg problem yet ;)

It is. don't you see the fix in SpDropListItem comparison?

@demarey demarey merged commit d49fe07 into pharo-spec:Pharo12 Dec 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants