Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug points api improvements #16861

Open
wants to merge 5 commits into
base: Pharo13
Choose a base branch
from

Conversation

StevenCostiou
Copy link
Collaborator

Renamings, api, etc.

@@ -32,5 +32,5 @@ SycOpenDebuggingPointsInMethodMenuCommand >> defaultMenuIconName [
{ #category : 'accessing' }
SycOpenDebuggingPointsInMethodMenuCommand >> defaultMenuItemName [

^ 'Debug Points'
^ 'Break'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 'Debug'

@@ -35,5 +35,5 @@ SycOpenDebuggingPointsMenuCommand >> defaultMenuIconName [
{ #category : 'accessing' }
SycOpenDebuggingPointsMenuCommand >> defaultMenuItemName [

^ 'Debug Points'
^ 'Break'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 'Debug'

@Ducasse
Copy link
Member

Ducasse commented Aug 2, 2024

Hello what is the status of this issue?

@StevenCostiou
Copy link
Collaborator Author

some of the failing tests are scary, some message seem to be not implemented but not sent.
but i don't think it is related to this particular pr

@adri09070 adri09070 closed this Aug 2, 2024
@adri09070 adri09070 reopened this Aug 2, 2024
@adri09070
Copy link
Collaborator

unrelated failing tests

@demarey demarey closed this Sep 9, 2024
@demarey demarey reopened this Sep 9, 2024
@demarey demarey closed this Sep 9, 2024
@demarey demarey reopened this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants