dns/pfSense-pkg-bind: fixes and improvements. Implement #14314, Fix #11563, Fix #10693 #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng config update. Add Validation to zone db on config change to prevent replacing a valid zone.db with invalid custom zone data which prevents BIND from loding the zone. Incrementing serial during zone update.
…finished, instead using the asynchronous version which could lead to read or write zone db before freze or sync is completed.
|
Please rebase and squash commits to one per feature or redmine issue. |
marcos-ng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine issue #14314
Redmine issue #11563
Redmine issue #10693
new GUI options
Changes to bind.inc:
Added logic to detect zone config changes and update zone.db only if required.
Added ability to merge all zone records from existing zone.db bevor overwriting with new zone config.
Includes detection of deleted and added records of custom zone data and manual entries.
Current zone data is parsed with named-compilezone. Fallback to overwrite zone.db if current zone data can not be validated.
Added validation of Zone.db bevor overwriting the existing zone with named-checkzone.
If validation fails, a notice is generated and bind uses the old zone.db until the new zone is valid.
Changed service restart behaviour to use "reconfigure" instead. Includes fallback to restart service if reconfigure fails.
Escaping TXT and SPF zone records