Changed how tls for postgres is configured. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
petrpavlik
requested changes
Dec 29, 2023
|
I'll take a look at why the CI failed. Does not seem to be related to changes in this PR. |
|
I think it's the `firebaseDefaultUserToken()` test is failing when trying to get `TEST_FIREBASE_USER_EMAIL` from environment?
… 2023年12月30日 01:32，Petr Pavlik ***@***.***> 写道：
I'll take a look at why the CI failed. Does not seem to be related to changes in this PR.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Now only production environment will force the use of an TLS configuration, testing and development envs disable TLS by default.
|
Thanks! I’ll fix the CI and merge it in tomorrow. |
|
I've tried to update an app I'm running on Digital Ocean (managed postgres) with this new code and it wound not connect, so I've updated this PR back to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation silences xCode warnings by replacing the deprecated function.
According to documentation,
TLS.prefer(_ sslContext: NIOSSLContext)will Try to create a TLS connection to the server. If the server supports TLS, create a TLS connection. If the server does not support TLS, create an insecure connection.This fix makes sure app is able to build and run if TLS is not configured properly.